Closed arunkannawadi closed 1 year ago
Merging #11 (af57d7e) into main (71c8664) will decrease coverage by
42.09%
. The diff coverage is42.60%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #11 +/- ##
===========================================
- Coverage 85.98% 43.90% -42.09%
===========================================
Files 19 21 +2
Lines 1042 1123 +81
Branches 109 107 -2
===========================================
- Hits 896 493 -403
- Misses 123 622 +499
+ Partials 23 8 -15
Impacted Files | Coverage Δ | |
---|---|---|
tests/test_GridContainer.py | 6.59% <0.00%> (-91.82%) |
:arrow_down: |
tests/test_UniformGrid.py | 27.41% <0.00%> (-69.64%) |
:arrow_down: |
tests/test_coadds.py | 32.00% <0.00%> (-66.00%) |
:arrow_down: |
python/lsst/cell_coadds/_stitched_image_planes.py | 47.61% <37.50%> (-25.40%) |
:arrow_down: |
python/lsst/cell_coadds/_grid_container.py | 40.29% <40.29%> (ø) |
|
python/lsst/cell_coadds/_UniformGrid.py | 48.48% <48.48%> (ø) |
|
python/lsst/cell_coadds/_stitchedPsf.py | 51.35% <51.35%> (ø) |
|
python/lsst/cell_coadds/_stitched_coadd.py | 46.42% <57.14%> (-36.60%) |
:arrow_down: |
python/lsst/cell_coadds/_exploded_coadd.py | 40.00% <75.00%> (-33.34%) |
:arrow_down: |
python/lsst/cell_coadds/__init__.py | 100.00% <100.00%> (ø) |
|
... and 18 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I'm going to fix mypy
errors after #13 is merged.
@TallJimbo Since you last reviewed, I've made some trivial changes mostly to please mypy and fix some failing tests (due to change in the iterator). I'm also relying solely on the mypy reusable workflow and removing mypy check from tests.yaml, because they seem to have become incompatible with each other (likely due to different set of packages installed, I think). Let me know if you'd like to review the changes again. If not, I'll fixup the new commits and merge it early next week.
Doesn't sound like I need to take another look.
Fair enough. I've fixed up the commits and everything is green. I'll merge this tomorrow FWIW.
This is the main PR that effects most of the changes, while keeping the more distracting and more trivial changes in #13 .