search

lsst / cell_coadds

LSST Data Management: Data Structures defining the cell-based coadds
GNU General Public License v3.0
2 stars 0 forks source link

DM-37494: Improve test coverage #12

Closed arunkannawadi closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #12 (d7357e8) into main (dd26113) will increase coverage by 1.49%. The diff coverage is 79.79%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   69.32%   70.82%   +1.49%     
==========================================
  Files          16       18       +2     
  Lines         890      946      +56     
  Branches       95      105      +10     
==========================================
+ Hits          617      670      +53     
- Misses        265      266       +1     
- Partials        8       10       +2
Impacted Files Coverage Δ
tests/test_stitchedPsf.py 54.05% <54.05%> (ø)
tests/test_common.py 94.00% <94.00%> (ø)
python/lsst/cell_coadds/_GridContainer.py 100.00% <100.00%> (+9.43%) :arrow_up:
tests/test_GridContainer.py 98.42% <100.00%> (+0.01%) :arrow_up:
tests/test_UniformGrid.py 97.43% <100.00%> (+0.37%) :arrow_up:
python/lsst/cell_coadds/_stitched_image_planes.py 47.61% <0.00%> (-3.05%) :arrow_down:
python/lsst/cell_coadds/_cellCoaddBuilder.py 42.00% <0.00%> (-0.72%) :arrow_down:
python/lsst/cell_coadds/_image_planes.py 65.15% <0.00%> (-0.33%) :arrow_down:
python/lsst/cell_coadds/_common_components.py 81.57% <0.00%> (+1.09%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

arunkannawadi commented 1 year ago

I've learned some things here about coverage configuration that I'm looking forward to applying in middleware packages, too.

I'm very glad about that! I pushed a pre-commit hook that will check the validity of the config file, if changed. This could be helpful if you'd like to play with the configs elsewhere as well.

I almost commented that your logic to build a simple MultipleCellCoadd data structure for testing should get moved to test_utils.py

It could still go there and get called once in setUpClass. I was also considering that at some point.

arunkannawadi commented 1 year ago

The pre-commit hook I added that checks the validity of the codecov config works fine on my local dev environment (at USDF). I've checked it explicitly by making the config file invalid and ensuring that the pre-commit hook notifies me of that. But pre-commit.ci fails to reach the server on Github Actions. This is not a required check at the moment, and I am going to ignore this for now, since the pre-commit hook is intended to be on the developer side of things, not necessarily as a CI/CD functionality.