search

lsst / cell_coadds

LSST Data Management: Data Structures defining the cell-based coadds
GNU General Public License v3.0
2 stars 0 forks source link

Noise realizations should also be sequence of MaskedImage #22

Open esheldon opened 1 year ago

esheldon commented 1 year ago

https://github.com/lsst/cell_coadds/blob/88a373ac7738320530baad8b2eeedd49f9e93fcc/python/lsst/cell_coadds/_image_planes.py#L81

They use the same variance and mask as the image.

I think this can be accomplished by making do something like this:

return [MaskedImageF(noise, self.mask, self.variance) for noise in self.noise_images]

Is the PSF already set in the ImageF?

TallJimbo commented 1 year ago

That list comprehension is fine, and we could add it as a new property, e.g. noise_realizations_with_mask_and_variance (naming is hard). I would like to keep the original as a clearer representation of what's actually stored.