search

lsst / cell_coadds

LSST Data Management: Data Structures defining the cell-based coadds
GNU General Public License v3.0
2 stars 0 forks source link

DM-43586: Add versioning to the fits module #32

Closed arunkannawadi closed 6 months ago

arunkannawadi commented 7 months ago

This is ready for another round of review, Jim.

arunkannawadi commented 7 months ago

I'm afraid it seems we didn't land on the same page as much as we both thought after talking about it live.

My bad. My scant notes of our discussion partly to blame here. Let's revisit this again next week. I think versioning is important since this is a dataset that is likely to be bulk-downloaded and accessed outside of RSP so I'd like to get a good versioning scheme going on.

arunkannawadi commented 6 months ago

I've switched to using just major and minor versions, and removed any mention of semantic versioning. I've expanded on the policy on bumping versions and compatibility across versions is largely put in by hand. I'm hoping to wrap this up, barring any minor implementation changes after today.

arunkannawadi commented 6 months ago

Thinking about this more after the call, I am with your points stronger than I was during the call. I'll clean up the changes and merge by EOD tomorrow. Thank you for all the discussions, Jim.