search

lsst / cell_coadds

LSST Data Management: Data Structures defining the cell-based coadds
GNU General Public License v3.0
2 stars 0 forks source link

DM-35300: Make cell-based coadds pickle-able #4

Closed arunkannawadi closed 2 years ago

arunkannawadi commented 2 years ago

Creating a PR in draft mode for some early comments.

  1. The UniformGrid was quite simple to implement the pickle in pybind11.
  2. The GridContainer and its builder need quite some logic to be done while dumping and then loading, so I chose to use continueClass and implement them in python.
  3. Pickling and unpickling seem accurate, but the equality fails, probably because there is no explicit definition of __eq__ for these objects unlike UniformGrid.

Things on to-do list:

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@96d1418). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   71.33%           
=======================================
  Files           ?       14           
  Lines           ?      757           
  Branches        ?       91           
=======================================
  Hits            ?      540           
  Misses          ?      210           
  Partials        ?        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96d1418...044c296. Read the comment docs.

arunkannawadi commented 2 years ago

Thanks, Jim. Fixed a small typo in README and going to try the auto-merge option.