search

lsst / cell_coadds

LSST Data Management: Data Structures defining the cell-based coadds
GNU General Public License v3.0
2 stars 0 forks source link

DM-37287: Remove GridIdentifiers #8

Closed arunkannawadi closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #8 (daa5112) into main (cd59df8) will decrease coverage by 0.28%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   67.98%   67.69%   -0.29%     
==========================================
  Files          15       15              
  Lines         862      845      -17     
  Branches      111       92      -19     
==========================================
- Hits          586      572      -14     
+ Misses        269      266       -3     
  Partials        7        7
Impacted Files Coverage Δ
python/lsst/cell_coadds/_cellCoaddBuilder.py 43.26% <100.00%> (ø)
python/lsst/cell_coadds/_identifiers.py 89.18% <100.00%> (+2.15%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

arunkannawadi commented 1 year ago

It doesn't break the build or existing unit tests (not surprising this GridIdentifiers doesn't have unit tests). Testing locally with by building the coadds (which is how I identified the change in MultipleCellCoadd class. Once the local test passes, I'll merge this. More unit tests to do this automatically coming soon.