search

lsst / pipe_tasks

LSST Data Management: astronomical data processing tasks
http://dm.lsst.org/
GNU General Public License v3.0
18 stars 18 forks source link

Unused `background` arg in `characterizeImageTask.run` #513

Open danjampro opened 3 years ago

danjampro commented 3 years ago

Hi - I've come across what appears to be an unused arg in characterizeIamgeTask.run:

https://github.com/lsst/pipe_tasks/blob/0c551f46038fc796e24d1590a7eb8537ebefe12a/python/lsst/pipe/tasks/characterizeImage.py#L443

Specifically the background input is not used, and the variable is reassigned here:

https://github.com/lsst/pipe_tasks/blob/62ad60b1454ba5f6deb0005f2fcbe1dcdc355364/python/lsst/pipe/tasks/characterizeImage.py#L482

laurenam commented 3 years ago

Looks like the check for a supplied background got lost in this commit: https://github.com/lsst/pipe_tasks/commit/1a9814c8e3ef818b1e38bc004f23d0b53d7400db