search

lsst / rubin_sim

Scheduler, survey strategy analysis, and other simulation tools for Rubin Observatory.
https://rubin-sim.lsst.io
GNU General Public License v3.0
41 stars 37 forks source link

OPSIM-1086: remove obsolete code and simplify upkeep of example_scheduler #372

Closed rhiannonlynne closed 11 months ago

rhiannonlynne commented 12 months ago

This PR was started to simplify some of the code in the footprints file (mostly, removing functions which were unused at this time and replaced by SkyAreaGenerators). Removing code which has names like wfd_healpixels which could tempt users to try to define the WFD by these functions -- but that we don't keep up to date with current definitions -- seems like good preventative maintenance.

And then I removed some extraneous code from the example_scheduler file, and wanted to be able to use the arg parser to set standard arguments for the baseline survey while using a notebook .. and maybe to keep the example_scheduler up to date with the evolving baseline more easily. So there are changes in this file as well.

I also moved some of what I see being used as standard changes to some of the keyword arguments for the sky_area classes into these classes directly. This should help avoid people missing these updates if they don't notice the kwarg being set in the simulation files.

rhiannonlynne commented 11 months ago

I tried to do them in separate commits, but for some of them it was a bit too entangled. Ah - right, maybe also the thing is that most of the time ruff complains about docstring lines being too long. So most of "ruff" changes are due to that. Sometimes ruff complains about unused variables though, so those are also in the same changes due to ruff. I could just label them all "ruff" I suppose.