search

lsst / rubin_sim

Scheduler, survey strategy analysis, and other simulation tools for Rubin Observatory.
https://rubin-sim.lsst.io
GNU General Public License v3.0
41 stars 37 forks source link

Incremental template metric #389

Closed ebellm closed 7 months ago

rhiannonlynne commented 8 months ago

Edit to say never mind about the merge problem, I was misinterpreting the unit test failures. Basically, instead - run black.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (87dd9cc) 55.33% compared to head (78851ce) 55.25%. Report is 3 commits behind head on main.

:exclamation: Current head 78851ce differs from pull request most recent head e5781f8. Consider uploading reports for the commit e5781f8 to get more accurate results

Files Patch % Lines
...bin_sim/maf/metrics/incremental_template_metric.py 19.71% 57 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #389 +/- ## ========================================== - Coverage 55.33% 55.25% -0.09% ========================================== Files 304 305 +1 Lines 29609 29681 +72 Branches 4282 4285 +3 ========================================== + Hits 16385 16400 +15 - Misses 12281 12338 +57 Partials 943 943 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rhiannonlynne commented 8 months ago

@ebellm you can merge this is you'd like, or I can go ahead. If you have additional changes you'd like to add, let me know and we can wait.