Closed rmandelb closed 5 months ago
Boris has made great progress towards reformulating this metric and incorporating it into his code in #397 . We have a few more checks to do once NERSC is back up tomorrow, but I'm confident that his approach is going to work, so I'm closing this draft PR. Thanks, Peter and Lynne, for all the advice about how to formulate these new summary metrics.
This draft PR is for the new summary metric (based on this notebook). The work is not yet complete, with 2 TODOs listed at the top and one in the middle (comment beginning with ###). These include:
run()
).run()
).I plan to work on it more in the morning, but there's already a lot there so I wanted to get some eyes on it. Advice on the above is welcome. (With these things still to do, I haven't been able to run this yet, so I am sure there are bugs.)