search

lstagner / ConcaveHull.jl

Julia package for calculating 2D concave/convex hulls
Other
28 stars 13 forks source link

Suggestion: Add flag to check if the algorithm is successful #15

Closed arnauqb closed 3 years ago

arnauqb commented 3 years ago

For my own project, I needed to make sure that the ConcaveHull had built correctly when passing it a list of points. Currently, if the algorithm fails to converge it prints an informative message, but I don't think there is anyway to actually check if it has converged.

The simplest way I thought this could be added is by adding an extra field to the Hull structure. I don't know if this is ideal, and I don't know if a function converged(hull::ConcaveHull.Hull) could be written that returned the flag rather than hard coding it.

arnauqb commented 3 years ago

Thanks for merging this @lstagner .Can you tag a release so it's in the registry?

Edit: I just learned about the #master syntax in Pkg, that lets me get the master version, so, no rush!