lsug / lsug-website

Source code of the London Scala User Group Website (yet to be hosted)
GNU General Public License v3.0
3 stars 20 forks source link

mill.scalalib.GenIdea/idea fails with netty-transport-native-epoll as dependency #130

Closed kxa14 closed 3 years ago

kxa14 commented 3 years ago

mill.scalalib.GenIdea/idea fails with the following error when executing on a project that has netty-transport-native-epoll as a dependency.

1 targets failed
mill.scalalib.GenIdea.idea java.nio.file.NoSuchFileException: ~/.cache/coursier/v1/https/repo1.maven.org/maven2/io/netty/netty-transport-native-epoll/4.1.46.Final/netty-transport-native-epoll-4.1.46.Final-linux-x86_64.pom

It's complaining about a missing pom file which has a linux-x86_64 suffix. Looking into the ~/.cache/coursier.../4.1.46.Final directory, we can see the said pom file does not exists, whereas a pom file without the suffix exists.

 ~/coursier/v1/https/repo1.maven.org/maven2/io/netty/netty-transport-native-epoll/4.1.46.Final:
   netty-transport-native-epoll-4.1.46.Final-linux-x86_64.jar
   netty-transport-native-epoll-4.1.46.Final-sources.jar
   netty-transport-native-epoll-4.1.46.Final.pom 

The issue seems to come from the logic in GenIdeaImpl looks for a POM extension with the same filename as the jar which does not cater for classifiers.

We think one solution to resolve this issue is to change the code to look for any file with a POM extension in the same directory as the jar.

More detailed information by @zainab-ali can be found here https://github.com/lsug/lsug-website/issues/90

Would you like us to PR this change? Also, thank you for working on and maintaining this build tool. Our project has benefited a lot from this project.

zainab-ali commented 3 years ago

Thanks @kxa14! I've a few suggestions:

zainab-ali commented 3 years ago

One other thing - you can mention me too.

More detailed information by @zainab-ali can be found here #90

That means I'll automatically get notified by GitHub when you open the issue.

If you like, you can edit this issue description with the suggestions (click the ... next to the issue description, and select edit) and I can take another look.

kxa14 commented 3 years ago

Thanks for the suggestions :smiley: I've edited the issue description. Please let me know if further changes are required.

zainab-ali commented 3 years ago

@kxa14 it looks great! Go ahead and open it in mill.

kxa14 commented 3 years ago

Done it :smiley: We can close this issue now. Thanks for your help :smile: