search

lsug / lsug-website

Source code of the London Scala User Group Website (yet to be hosted)
GNU General Public License v3.0
3 stars 20 forks source link

GitHub Actions: ci.synth failed #69

Closed zainab-ali closed 3 years ago

zainab-ali commented 3 years ago

The GitHub Actions build fails following the updates made by scala steward.

This can be seen by the red x on the main GitHub branch, and the recent actions workflows:

warning package.json: No license field
$ /home/runner/work/lsug-website/lsug-website/out/ci/yarn/dest/node_modules/.bin/cdk synth
/bin/sh: 1: ./stack.sc: Permission denied
Subprocess exited with error 126
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
1 targets failed
ci.synth ammonite.ops.InteractiveShelloutException
    ammonite.ops.Shellout$.executeInteractive(Shellout.scala:56)
    ammonite.$file.webpack$Yarn.$anonfun$$percent$3(webpack.sc:24)
    ammonite.$file.webpack$Yarn.$anonfun$$percent$3$adapted(webpack.sc:24)
    ammonite.ops.Command.applyDynamic(Shellout.scala:118)
    ammonite.$file.webpack$Yarn.$percent(webpack.sc:26)
    ammonite.$file.build$ci$.$anonfun$synth$2(build.sc:230)
    mill.define.ApplyerGenerated.$anonfun$zipMap$8(ApplicativeGenerated.scala:19)
    mill.define.Task$MappedDest.evaluate(Task.scala:392)

The failure was introduced somewhere between the following commits (inclusive):

98d5cda | * 65 Update cats-core to 2.2.0
3a24d17 *   Merge pull request #63 from scala-steward/update/scalafmt-core-2.4.2

I'm firing off the GitHub actions of each one to find the culprit.

zainab-ali commented 3 years ago

Commit 92bce8b is green. So a previous build, if rebuilt, succeeds, but the current one fails. While there isn't anything in the commit history that should cause this, this points to an upgrade issue. I'm trying c6ff2d3.

zainab-ali commented 3 years ago

The command ci.synth fails locally too :tada:. Finding the upgrade should be much easier.

zainab-ali commented 3 years ago

This seems to be the culprit:

3a24d17 *   Merge pull request #63 from scala-steward/update/scalafmt-core-2.4.2
zainab-ali commented 3 years ago

This line is the culprit:

https://github.com/lsug/lsug-website/pull/63/files#diff-8297b6d7bda68cb0a99911f5f9d80c9781c391fee038cce26551a3a964d6619eR1

It looks to be a scalafmt formatting issue of the stack.sc.