search

lsuits / OBSOLETE--DO-NOT-USE--gradebook_moodle

LSU's fork of Moodle for gradebook changes
GNU General Public License v3.0
2 stars 1 forks source link

Aggregation change upsets extra credit #26

Closed rrusso closed 12 years ago

rrusso commented 12 years ago

When changing aggregation methods from weighted mean to any other agg method, items change from + to - and from - to +.

When changing aggregation methods from any other agg method to weighted mean, items change from + to - and from - to +.

rrusso commented 12 years ago

The + to - and - to + alters extra credit.

philcali commented 12 years ago

This is specifically talking about their weight value, and not their actual value, right?

rrusso commented 12 years ago

Yes. That would be very confusing indeed.

philcali commented 12 years ago

Currently, there is no aggregationcoef change, but it needs to. One important thing to note about doing this: items with significant weight will be lost (weight loss, ha) after the aggregation change. I imagine this could better be explained as expected behavior, than having items with significant weight turn into extra credit items (that looks more like a bug).

rrusso commented 12 years ago

Agreed. The aggregationcoef can change to 0 or 1 as required, but needs to not change from extra credit to credit or vice versa for every switch.

rrusso commented 12 years ago

This would be a high-priority fix.

philcali commented 12 years ago

@rrusso This commit has been merged into consolidated... you should be able to safely pull to test changes. Please re-open if you run into any problems.

rrusso commented 12 years ago

Works great!