Percentage weight bug

[rrusso]

From Carey:

Now for the bad bit. in testing this, I randomly clicked on MC 2525 for Anne Osborne. There is something really strange going on with her category weighting. The actual percents, those that are in parenthesis by the category name have totals like (1000%) & (2000%).

She used whole numbers in her weight settings, so I suspect that is the problem. In previous Moode, you could use decimal or whole numbers, it didn't matter. Also one of her categies is weighted "20" but showing the actual percent of (0%). It has an extra credit item inside, so maybe that's the problem. I will look more into it, and contact the instructor to tell her that her grade totals are currently incorrect.

Looks like you are assuming out of 1 and not out of total to get percentages?

[philcali]

Category items parent category was incorrectly assumed to be the parent category. The grade API requires an additional call to retrieve the parent category.

$parent = $item->get_parent_category();
...

if ($item->is_category_item()) {    
    $parent = $parent->get_parent_category();
}

That was the only issue I found in testing.

[rrusso]

Sounds good. How do I test?

[philcali]

In branch: weighted_percentages. Apply the setting Show weighted percentages in the Gradebook preference page at the course level.

[rrusso]

Wow.

Not even close.

Now it will not show percentages for the category and shows percentages for SWM and SUM items in the cats.

Example Course ( Weighted Mean )

• SWM ( 10 )
  • Quiz 1
  • Quiz 2
  • Quiz 3
  • Quiz 4
  • Quiz 5
  • Quiz 6
  • EC SWM
• SUM ( 20 )
  • Homework 1
  • Homework 2
  • Homework 3
  • Homework 4
  • Homework 5
  • Homework Extra Credit
• WM ( 70 )
  • Exam 1 ( 25 )
  • Exam 2 ( 25 )
  • Exam 3 ( 50 )
  • Exam Extra Credit ( -1 )
• Course Extra Credit ( -1 )
  • EC 1
  • EC 2
  • EC 3

I get the following results in the gradebook:

• No weights on the categories
• Incorrect weights for each item in SWM, SUM, WM, and EC.

Example:

• SWM
  • Quiz 1 ( 16.61 )
  • Quiz 2 ( 16.61 )
  • Quiz 3 ( 16.61 )
  • Quiz 4 ( 16.61 )
  • Quiz 5 ( 16.61 )
  • Quiz 6 ( 16.61 )
  • EC SWM ( 0.33 )

Weights should only show up in weighted mean categories for both cats and items.

Under NO circumstances should weights show up in SWM and SUM.

And they are not correct. Extra credit should not be weighted .33 percent.

[philcali]

The only problem was that the weight was calculated for extra credit items.

This statement is wrong and unreasonably narrow:

Under NO circumstances should weights show up in SWM and SUM.

Weights are calculated for items in these aggregation methods instead of given (like WM), so I say why not?

I updated the branch.

[rrusso]

I see your point. At least make sure the weights are correct.

[rrusso]

See my latest email

exam 1 ( 25 ) exam 2 ( 25 ) exam 3 ( 50 ) exam extra credit ( -1 - extra credit checked )

Shows up as

exam 1 ( 25.25% ) exam 2 ( 25.25% ) exam 3 ( 50.51% ) exam extra credit ( -1.01% - extra credit checked )

So we have 101.01% - extra credit of 1.01% to = 100%...weird.

[rrusso]

This issue only occurs in WM as far as I can tell.

[philcali]

It was > 0 instead of < 0. Also, this branch alone does not recognize WM as an extra credit category (because Moodle doesn't). You'd have to merge in the changes with weighted_mean_ec to a see a difference.

[philcali]

I'd also add: the real test is the consolidated branch, as it includes all the gradebook changes into a single branch.

[rrusso]

And how does one test this branch?

[philcali]

I never work off of consolidated as the changes are in the children branches. If you already have it locally: git branch -D consolidated. Add gradebook_moodle as a remote: git remote add gradebook git://github.com/lsuits/gradebook_moodle.git

Fetch consoldiated:

git fetch --no-tags gradebook consolidated:consolidated

Voila!

[rrusso]

Works great!