search

lsuits / OBSOLETE--DO-NOT-USE--gradebook_moodle

LSU's fork of Moodle for gradebook changes
GNU General Public License v3.0
2 stars 1 forks source link

Repeat Headers breaks IE8 and 9 #9

Closed rrusso closed 12 years ago

rrusso commented 12 years ago

I went to the link Philip included, and I had some problems with the headers that appear every so many students.

Here is a screen shot in Files to Geaux of my last group of students. The headers are over a student off in how they line up.

https://filestogeaux.lsu.edu/download.php?FILE=bmcman1/194153gCpQR

I am using IE 9.0.8112.16421. Wen's IE was a little off (he is still running a version of 8.0), but not this much, and his Firefox was fine. Just wanted you to be aware of this possible issue.

Barbara

rrusso commented 12 years ago

This one is more important, clearly.

philcali commented 12 years ago

I'm about 99.5% sure this isn't a repeat headers issue. Repeat headers did not change any of the styling, in fact. It just adds more rows to the left and right (it should handle this gracefully).

Also, the screenshot you linked me shows that repeat headers is not even activated.

What may be happening: IE 8 and 9 are not compensating for the extra data in the item header (percents, qe link, etc). The wrapping of the text may mis-align the headers to the students cells.

What are your thoughts on this?

rrusso commented 12 years ago

Except the issue starts before the qe row.

philcali commented 12 years ago

I does, and I don't know why. As a fun git exercise, I decided to see if any of the gradebook changes affected the styles.css on the grader report:

git diff v2.2.1 consolidated grade/report/grader/styles.css

The answer is no. I'm quite confident that problem existed before any work on the Gradebook happened. Any other IE atrocities are beyond the scope of the these changes.

philcali commented 12 years ago

I'd also add I also ran:

git diff v2.2.1 consolidated grade/report/grader/lib.php

Which encapsulates the html renderings, nothing more that colspan changes, text in the headers, and additional rows, if and only if, the number of student is more than the set reapeat header amount.

rrusso commented 12 years ago

DERP

They had it in IE7 compatibility mode.

I just tested in 9 without an issue.

philcali commented 12 years ago

Sweet. Then I'm closing this issue. IE is so user friendly! :fire: