search

lsuits / lsu-block_my_picture

A Moodle block that imports profile picture from a web service
1 stars 2 forks source link

Cron doesn't return #9

Closed philcali closed 12 years ago

philcali commented 12 years ago

Cron needs to return a boolean value for Moodle to fill in the lastcron field on the mdl_block table. If cron doesn't return or returns false, it is treated as a failed attempt.

In effect, this forces my_picture to process at every cron regardless of the hour interval placed on it.

rrusso commented 12 years ago

How long before we get a fix on this?

philcali commented 12 years ago

Well, this is not as bad as it sounds. It also only processed the users who do not have pictures, so after a certain point, it returns instantly because there is simply no more work to do. The real issue is when a lot of users are dumped in the system initially.

To answer your question, the fix is adding one one line in function cron which is return true; I can do this right here on github if we want.

rrusso commented 12 years ago

Please. I'd like this to go out with the GB fixes tomorrow.

philcali commented 12 years ago

Right on.