search

lsuits / lsu-gradereport_grade_breakdown

Grade analysis of course gradebook
2 stars 0 forks source link

Broken Images In Different Categories #6

Closed ghost closed 9 years ago

ghost commented 10 years ago

Hello,

I ran into a couple issues on Moodle 2.6 with broken images with the categories of Course Total, Homework, and Quizzes. When selecting on a range, a page pops up where each student that is in that range is listed. The right most column there should be an image there enabling the user to edit that student's score. However, this is where the issue lies. In Chrome/Safari, there is a broken image listed there. In Firefox, there is just the word "Edit" that is un-clickable. Please see attached pictures for reference.

Thank you,

Ben Tindell

safari firefox chrome

rrusso commented 10 years ago

Are you sure those screenshots are from this plugin?

ghost commented 10 years ago

Yes, the screenshots are from this plugin. On our instance, we've had the version without graphs for several months now. We recently upgraded the plugin to get the graphs. The error that I found occurs in the earlier version and in this most recent version.

rrusso commented 10 years ago

Dave will get right on it.

elliott2081 commented 10 years ago

Hello Ben, Basically what was happening is that icon is only in the LSU theme, and the missing image you were seeing was in this context used to show that something couldn't be edited. Firefox grabbed the alt text and made an auto image. I just went ahead and removed that icon as I believe that signals to the user that it's not editable. I'm curious about your first screen shot though, I am unable to reproduce that, on individual items, not categories or course totals, you should see the little pencil icon, which is moodle core so I'm not sure why that is not showing up.

rrusso commented 10 years ago

Why not include the icon in the GaaG plugin and change the location to point to the new icon?

elliott2081 commented 10 years ago

I think the icon is a bit misleading as it's used as a delete button in other places. The other thing I was considering was that either all of the entries will be editable or none will be, so I think for course total and category totals it might make sense to just not output the 'edit' column at all. Which would probably be the least confusing for users.

rrusso commented 10 years ago

I'll defer to your expertise. I'm on vacation anyway.

rrusso commented 9 years ago

The plugin uses the theme's /i/edit icon. If you don't have one, it's not the fault of this plugin as it's called elsewhere.