lsuits / lsu_xml_enrollment_provider

General purpose UES provider consuming XML enrollment files
0 stars 0 forks source link

lib.php changes #1

Open rrusso opened 10 years ago

rrusso commented 10 years ago

Please make all constants config options.

interface xml_semester_codes {
    const FALL = '1S';
    const SPRING = '2S';
    const SUMMER = '3S';
    const WINTER_INT = '1T';
    const SPRING_INT = '2T';
    const SUMMER_INT = '3T';
}

interface xml_institution_codes {
    const LSU_SEM = 'CLSB';
    const LAW_SEM = 'LAWB';

    const LSU_FINAL = 'CLSE';
    const LAW_FINAL = 'LAWE';

    const LSU_CAMPUS = '01';
    const LAW_CAMPUS = '08';

    const LSU_INST = '1590';
    const LAW_INST = '1595';
}

This way the end user does not have to conform to the silly semester/campus/term/codes we do.

jpeak5 commented 10 years ago

yep; getting to that; working on unsuring the base functionality before getting to fancy, too diverged; may have found a bug...

jrp


From: Robert Russo notifications@github.com Sent: Tuesday, May 13, 2014 3:33 PM To: lsuits/lsu_xml_enrollment_provider Subject: [lsu_xml_enrollment_provider] lib.php changes (#1)

Please make all constants config options.

interface xml_semester_codes { const FALL = '1S'; const SPRING = '2S'; const SUMMER = '3S'; const WINTER_INT = '1T'; const SPRING_INT = '2T'; const SUMMER_INT = '3T'; }

interface xml_institution_codes { const LSU_SEM = 'CLSB'; const LAW_SEM = 'LAWB';

const LSU_FINAL = 'CLSE'; const LAW_FINAL = 'LAWE';

const LSU_CAMPUS = '01'; const LAW_CAMPUS = '08';

const LSU_INST = '1590'; const LAW_INST = '1595';

}

This way the end user does not have to conform to the silly semester/campus/term/codes we do.

Reply to this email directly or view it on GitHubhttps://github.com/lsuits/lsu_xml_enrollment_provider/issues/1.

rrusso commented 10 years ago

Sweet.