lsuonline / lsuce-block_quickmail

5 stars 32 forks source link

Message recipients list ordered by first name is problematic #45

Open chrispa-auth opened 2 years ago

chrispa-auth commented 2 years ago

In the message composition form, where the recipients are listed, they are ordered by their first name. This is hard coded in classes\plugin.php function get_compose_message_recipients, line 265.

Please change this to use the fullname function of lib/moodlelib.php (i.e. change the line to $username = fullname($user);) in order to allow admins to configure how they want the user names displayed (and thus sorted).

We have a large installation of 54000 active users with many courses having a large audience and ordering the list of recipients by first name is by no means practical. The change we suggest will enable admins to choose how they want names displayed and sorted by setting the $CFG->fullnamedisplay variable which is a standard Moodle feature.

Moodle 3.9+ Quickmail 2.5.0