search

lsuonline / lsuce-block_quickmail

5 stars 32 forks source link

Courses with two block instances of quickmail causes "setting_already_added" exception during backup & restore #50

Open aspark21 opened 2 years ago

aspark21 commented 2 years ago

https://github.com/lsuits/lsu-block_quickmail/issues/72

Came across this again on Moodle 3.11.7 / latest quickmail master

This seemed relevant - https://docs.moodle.org/400/en/Development:Blocks#We_Are_Legion But this isn't defined so in theory Moodle shouldn't be allowing this.

Other references to this: https://moodle.org/mod/forum/discuss.php?d=236319 https://moodle.org/mod/forum/discuss.php?d=232768 https://tracker.moodle.org/browse/CONTRIB-4071

aspark21 commented 2 years ago

The only 2 changes since the initial commit of Quickmail are these and don't seem to affect this materially

https://github.com/lsuonline/lsuce-block_quickmail/commit/6bfdd958bbface1397652692e60d3ff427c33c8a#diff-546925695c3d77fdfd6c8a60a2848c92520da1f4146fb29842610f769e5ba13bL15

https://github.com/lsuonline/lsuce-block_quickmail/commit/474d4bfd337c6eba46228642d14adc3bebc472b9#diff-546925695c3d77fdfd6c8a60a2848c92520da1f4146fb29842610f769e5ba13bL72

The fact this screenshot https://github.com/lsuits/lsu-block_quickmail/issues/72#issuecomment-24727417 refers to course-edit pagetypepattern which is not defined . not sure why/what

weird