Open guillogo opened 1 year ago
The function these errors are reporting on does nothing other than return an array of empty arrays
private function get_recipients_array($recipients) {
$includedentityids = [];
$excludedentityids = [];
foreach (['included', 'excluded'] as $inclusiontype) {
if (array_key_exists($inclusiontype, $recipients)) {
foreach (['role', 'group', 'user'] as $recipienttype) {
if (array_key_exists($recipienttype, $recipients[$inclusiontype])) {
foreach ($recipients[$inclusiontype][$recipienttype] as $id) {
// Segun Babalola, 2020-10-30.
// Not sure how this ever worked with undescores.
// Recipient IDs will never have been captured.
$containername = $inclusiontype . 'entityids';
$containername[] = $recipienttype . '_' . $id;
}
}
}
}
}
return [$includedentityids, $excludedentityids];
}
Ah, I see from the referenced fix that it's a variable variable
Hi, there are 19 errors when executing unit test due to: https://github.com/lsuonline/lsuce-block_quickmail/blob/master/tests/unit/traits/submits_compose_message_form.php#L89