search

lsuonline / lsuce-block_quickmail

6 stars 37 forks source link

Fix for Message Duplication Error #74 #79

Open dustinbrisebois opened 1 year ago

dustinbrisebois commented 1 year ago

https://github.com/lsuonline/lsuce-block_quickmail/issues/74

Changing the call from $original to $new fixes the duplication error

Syxton commented 10 months ago

@dustinbrisebois I believe this change is incorrect. The real issue stems from classes/messenger/messenger.php on around line 473 & 474. The lines reference the wrong variable name.

    // Duplicate files.
    message_file_handler::duplicate_files($originaldraft, $newdraft, 'attachments');
    message_file_handler::duplicate_files($originaldraft, $newdraft, 'message_editor');

SHOULD BE

    // Duplicate files.
    message_file_handler::duplicate_files($originalmessage, $newdraft, 'attachments');
    message_file_handler::duplicate_files($originalmessage, $newdraft, 'message_editor');

I have pushed another request, this can be closed.