lsuonline / lsuce-block_quickmail

5 stars 32 forks source link

Fixed issue #71 #80

Open opitz opened 10 months ago

opitz commented 10 months ago

setting userteacher as user in tests before messenger::compose or messenger::save_compose_draft, restoring doubledollar in line 89 of submits_compose_message_form.php. This will fix issue #71.

aydevworks commented 10 months ago

I think it would be better to setup the $course, $userteacher, $userstudents and the global $USER variable in the setUp() function rather to have them setup in each test.

aydevworks commented 9 months ago

I think it would be better to setup the $course, $userteacher, $userstudents and the global $USER variable in the setUp() function rather to have them setup in each test.

But it would limit the flexibility of adding new tests which do not require the same setup, so I am fine with the fix. 😄