search

lswartsenburg / klaviyo-node

A third party maintained Node.js package for sending Klaviyo events
Apache License 2.0
1 stars 5 forks source link

Time tracking for transactional emails #19

Open freynolds opened 3 years ago

freynolds commented 3 years ago

Hi, first of all, let me tell you that Klaviyo Node is very useful to work with Klaviyo.

I was reading the documentation on transactional emails, to see if I could improve the speed those get sent. It reads that you need to send time as a UNIX timestamp, it doesn't specify why you need this, and for what I saw in your code, Klaviyo Node doesn't do that, and it works. I want to see if adding time speeds up transctional email sending. Would you be willing to accept a PR with this modification?

itsolucas commented 3 years ago

Hi Francisco,

Thanks for reaching out! I've temporarily lost access to the project, but am in the process of regaining it. Once that is done, I'll happily accept the contribution.

Best,

Lucas

On Wed, Sep 23, 2020 at 2:24 PM Francisco Reynolds notifications@github.com wrote:

Hi, first of all, let me tell you that Klaviyo Node is very useful to work with Klaviyo.

I was reading the documentation on transactional emails https://help.klaviyo.com/hc/en-us/articles/360038525651-Setting-Up-API-based-Transactional-Events, to see if I could improve the speed those get sent. It reads that you need to send time as a UNIX timestamp, it doesn't specify why you need this, and for what I saw in your code, Klaviyo Node doesn't do that, and it works. I want to see if adding time speeds up transctional email sending. Would you be willing to accept a PR with this modification?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/itso-io/klaviyo-node/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALWVBX45KI5JOWRD5ICXE6TSHHSIRANCNFSM4RW66KVQ .