search

lsymds / hetznercloud-py

Python SDK for the new Hetzner cloud
MIT License
30 stars 12 forks source link

FloatingIp field `ip` not parsed from api json #19

Closed svensp closed 6 years ago

svensp commented 6 years ago

I'm trying to identify an floating ip in the api by the ip address it represents. Unless I'm reading it wrong HetznerCloudFloatingIp._load_from_json does not parse that information yet.

I think the following would parse that information:

float_ip.ip = json["ip"]
ghost commented 6 years ago

Feel free to submit a pull request if you need it done as soon as possible, otherwise I will do it this weekend.

Thanks for the report!