search

lsymds / hetznercloud-py

Python SDK for the new Hetzner cloud
MIT License
30 stars 12 forks source link

Added alias for datacentres method and fixed typos #3

Closed brejoc closed 6 years ago

brejoc commented 6 years ago

In some places datacentre was used instead of datacenter.

ghost commented 6 years ago

Seems like my Britishness got the better of me.

Unfortunately, with this package now being released and ready for use in a production environment, I can't release a breaking change like this without increasing the major version of the library. I propose we have two options:

1) Leave it as it is. 2) Add another method to the HetznerCloudClient class called datacenters (which returns the result from the datacentres function). In layman's terms, create an alias.

Whatever route we take, thank you for your contribution.

brejoc commented 6 years ago

Okay, I see! :laughing: Then I'll change the PR, so that we have an alias. Would you prefer to have datacenters or datacentres as an alias.

ghost commented 6 years ago

I'd prefer datacenters to be the alias - cheers!

brejoc commented 6 years ago

Sorry, something went wrong with the merge. I have to take care of this tomorrow.

brejoc commented 6 years ago

@elsyms Okay, now we should be good to go. :smile:

brejoc commented 6 years ago

@elsyms Is there anything else that needs to be done here?

ghost commented 6 years ago

Thanks for your work on this. Will run the tests myself and deploy a new version sometime today.