Do not use global variables

[coudot]

We need to pass all parameters to functions and not rely on globals

[davidcoutadeur]

Implied modifications in the corresponding LTB projects:

• new method signature in AttributeValue: ldap_get_mail_for_notification($ldap, $entry, $mail_attributes) (new last argument)
• Mail.Php must now be instanciated with its constructor:

    function __construct( $mail_priority,
                          $mail_charset,
                          $mail_contenttype,
                          $mail_wordwrap,
                          $mail_sendmailpath,
                          $mail_protocol,
                          $mail_smtp_debug,
                          $mail_debug_format,
                          $mail_smtp_host,
                          $mail_smtp_port,
                          $mail_smtp_secure,
                          $mail_smtp_autotls,
                          $mail_smtp_auth,
                          $mail_smtp_user,
                          $mail_smtp_pass,
                          $mail_smtp_keepalive,
                          $mail_smtp_options,
                          $mail_smtp_timeout
                        )

• no more send_mail_global function
• use rather send_mail function, applied on the mailer object. take care to the new signature:

$mailer = new \Ltb\Mail(...);
$mailer->send_mail($mail, $mail_from, $mail_from_name, $subject, $body, $data) {

• Ldap.Php must now be instanciated with its constructor:

    public function __construct(
                          $ldap_url,
                          $ldap_starttls,
                          $ldap_binddn,
                          $ldap_bindpw,
                          $ldap_network_timeout,
                          $ldap_user_base,
                          $ldap_size_limit,
                          $ldap_krb5ccname
                      )

• all following functions must now be called on a Ldap instance: $ldapInstance = new \Ltb\Ldap(...); $ldapInstance->function(...):

connect
search
get_list
ldapSort
sorted_search
get_password_value
change_ad_password_as_user
change_password_with_exop
modify_attributes_using_ppolicy
modify_attributes

• all following functions from Ldap.php have a modified signature: they don't require $ldap as first parameter any more:

get_list
sorted_search
get_password_value
change_ad_password_as_user
change_password_with_exop
modify_attributes_using_ppolicy
modify_attributes

• Method search from LtbUtil.php has been moved to Ldap.php. It also has a new signature: (and it must be called on a ldap instance object, as described above)

// old signature:
    function search($ldap_filter,$attributes)
// new signature:
    function search($ldap_filter,$attributes, $attributes_map, $search_result_title, $search_result_sortby, $search_result_items)
    {

[davidcoutadeur]

Refactoring seems ready now.

I have tested and adapted self-service-password to the ltb-ldap changes

We'll have to:

• adapt also white-pages and service-desk
• release an official v0.2.0 of ltb-ldap