ltb-project / openldap-deb

Debian packages for OpenLDAP
http://ltb-project.org/wiki/documentation/openldap-deb
GNU General Public License v3.0
14 stars 13 forks source link

make openldap ltb deb pass lintian checks #15

Closed davidcoutadeur closed 5 years ago

davidcoutadeur commented 6 years ago

See:

lintian -c openldap-ltb_2.4.46.1_amd64.deb 
warning: the authors of lintian do not recommend running it with root privileges!
W: openldap-ltb: debian-changelog-line-too-long line 4
W: openldap-ltb: debian-changelog-line-too-long line 5
W: openldap-ltb: debian-changelog-line-too-long line 9
W: openldap-ltb: debian-changelog-line-too-long ... use --no-tag-display-limit to see all (or pipe to a file/program)
E: openldap-ltb: file-in-usr-marked-as-conffile usr/local/openldap/etc/openldap/slapd.conf
E: openldap-ltb: file-in-usr-marked-as-conffile usr/local/openldap/etc/openldap/slapd-cli.conf
E: openldap-ltb: file-in-usr-marked-as-conffile usr/local/openldap/etc/openldap/ldap.conf
E: openldap-ltb: file-in-usr-marked-as-conffile ... use --no-tag-display-limit to see all (or pipe to a file/program)
W: openldap-ltb: unknown-control-file vars
E: openldap-ltb: helper-templates-in-copyright
W: openldap-ltb: readme-debian-contains-debmake-template
W: openldap-ltb: spelling-error-in-description librairies libraries
E: openldap-ltb: dir-in-usr-local usr/local/openldap/
E: openldap-ltb: dir-in-usr-local usr/local/openldap/bin/
E: openldap-ltb: file-in-usr-local usr/local/openldap/bin/ldapadd
W: openldap-ltb: file-in-unusual-dir usr/local/openldap/bin/ldapadd
E: openldap-ltb: file-in-usr-local usr/local/openldap/bin/ldapcompare
W: openldap-ltb: file-in-unusual-dir usr/local/openldap/bin/ldapcompare
E: openldap-ltb: file-in-usr-local usr/local/openldap/bin/ldapdelete
W: openldap-ltb: file-in-unusual-dir usr/local/openldap/bin/ldapdelete
E: openldap-ltb: file-in-usr-local ... use --no-tag-display-limit to see all (or pipe to a file/program)
W: openldap-ltb: file-in-unusual-dir ... use --no-tag-display-limit to see all (or pipe to a file/program)
E: openldap-ltb: dir-in-usr-local usr/local/openldap/etc/
E: openldap-ltb: dir-in-usr-local ... use --no-tag-display-limit to see all (or pipe to a file/program)
E: openldap-ltb: prerm-calls-updaterc.d slapd
E: openldap-ltb: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/slapd
W: openldap-ltb: command-with-path-in-maintainer-script postinst:8 /usr/sbin/addgroup
W: openldap-ltb: command-with-path-in-maintainer-script postinst:9 /usr/sbin/adduser
W: openldap-ltb: command-with-path-in-maintainer-script postinst:37 /bin/chown
W: openldap-ltb: command-with-path-in-maintainer-script ... use --no-tag-display-limit to see all (or pipe to a file/program)
W: openldap-ltb: maintainer-script-ignores-errors postinst
W: openldap-ltb: maintainer-script-ignores-errors prerm
W: openldap-ltb: maintainer-script-ignores-errors vars
E: openldap-ltb: non-empty-dependency_libs-in-la-file usr/local/openldap/lib64/liblber.la
E: openldap-ltb: non-empty-dependency_libs-in-la-file usr/local/openldap/lib64/libldap.la
E: openldap-ltb: non-empty-dependency_libs-in-la-file usr/local/openldap/lib64/libldap_r.la
E: openldap-ltb: non-empty-dependency_libs-in-la-file ... use --no-tag-display-limit to see all (or pipe to a file/program)
W: openldap-ltb: package-has-unnecessary-activation-of-ldconfig-trigger
W: openldap-ltb: init.d-script-does-not-source-init-functions etc/init.d/slapd
davidcoutadeur commented 6 years ago

@stroeder @konqui15: for information

davidcoutadeur commented 6 years ago

Done in main openldap package. (see 26da08d) file-in-usr-marked-as-conffile is unoverridable without using a profile. Thus you need to install main package and then use a command like:

lintian -v --profile debian/openldap-ltb -c openldap-ltb_2.4.46.1_amd64.deb

(profile is installed by default in /usr/share/lintian/profiles/debian/openldap-ltb.profile

Need to do the same for all sub packages

davidcoutadeur commented 6 years ago

Done for all packages in 255b2d9 Need to test deeply package installation / upgrade / purge to ensure there is no regression

davidcoutadeur commented 6 years ago

First tests seem ok