ltb-project / self-service-password

Web interface to change and reset password in an LDAP directory
https://self-service-password.readthedocs.io/en/latest/
GNU General Public License v3.0
1.18k stars 327 forks source link

Strategy for composer dependencies #929

Closed davidcoutadeur closed 5 months ago

davidcoutadeur commented 5 months ago

This issue is here to discuss the strategy for composer dependencies.

Depending on the operating system, and especially the php version, the composer dependencies won't be the same.

For example, in 2024 of July, we still propose self-service-password package on old systems like EL7. (php 7.4)

I think it is preferable to let people generate this file by themselves. This implies:

coudot commented 5 months ago

My point of view is that composer is only needed for dev.

We choose to provide vendor/ in our distribution tarball and in our packages, no one needs to run composer in this case.

So removing composer.lock is ok for me. Documentation is needed only for dev.

davidcoutadeur commented 5 months ago

I am ok with that. I will do the modifications.

davidcoutadeur commented 5 months ago

Done in f586c00 + cd3826b