ltb-project / service-desk

Application for support team who need to check and reset user passwords
https://service-desk.readthedocs.io/
GNU General Public License v3.0
49 stars 20 forks source link

Send a mail to administrator #73

Closed coudot closed 1 year ago

coudot commented 1 year ago

Linked to #71 and #72

If administrator identity is known, send a mail to confirm the action has been done. It will be a configuration option of course.

artlog commented 1 year ago

I propose a $notify_admin_by_mail containing the mail to be notified. For sake of simplicity it is better to have only one mail. If multiple people need to be contacted , then a common mail for all should be used. This can help admin team to know if pending client request was fulfilled.

When $notify_admin_by_mail is set any successful password change will be notified to this mail. list of additional actions to cover could be done in a second step.

What should we include in this mail ? any additional information we can gather about web client ?

cmaudoux commented 1 year ago

Hello,

The idea is to send an email to the admin who resets the password. By admin I mean the user using the service desk. Admin's email can be retrieved from an HTTP header that can be defined like multi tenancy param or from the LDAP itself if admin's identity is known (HTTP header).

Email body could be an external file where some specific variables like __PASSWD__ or __USER__ should be replaced.

artlog commented 1 year ago

would HTTP_ORIGINATOR_MAIL be a right header name ? @cmaudoux

coudot commented 1 year ago

Whatever, this header name will be a configuration parameter.

I wonder if we would need 2 options:

Options can be enabled separately or at the same time. The second is interesting so any admin will be alerted when a user account is modified.

Another point: I would not send the password in this mail. This mail should only notice admin(s) that the user account has been reset.

cmaudoux commented 1 year ago

I agree with @coudot

Cheers

artlog commented 1 year ago

working on it.

cmaudoux commented 1 year ago

Thanks