ltcmelo / psychec

A compiler frontend for the C programming language
BSD 3-Clause "New" or "Revised" License
536 stars 39 forks source link

Update Psychec's CI to use C++17 #41

Open aytey opened 3 years ago

aytey commented 3 years ago

Is your feature request related to a problem? Please describe.

PR #40 "fell over" because it used the legally-allowed C++17 header filesystem, but this does not actually exist in psychec CI base image:

Describe the solution you'd like

Update the GitHub actions to use a more-modern Ubuntu or look at using a later GCC within 18.04

Describe alternatives you've considered

Change PR #40 to not use filesystem (even though it is in C++17 😞)

Additional context

Build log from #40: https://github.com/ltcmelo/psychec/pull/40/checks?check_run_id=2161399189#step:4:65

ltcmelo commented 3 years ago

I didn't know about such ubuntu "situation"… it appears that it needs <experimental/filesystem> (with extra link flags). But I think this can be handled in the Cmake file and with a preprocessing directive to choose between <filesystem> and <experimental/filesystem> ?

(Added further comments in the PR)