search

ltdelia / TrainTime

Train Schedule App
https://choochoocheechee.firebaseapp.com/
0 stars 0 forks source link

HW 7 Review #1

Open faisalrcb opened 8 years ago

faisalrcb commented 8 years ago

Good start, however your js and file is not loading. There is some error when I check console. This may be a reason your code is not working as expected.

Also your variables that you are performing the math on, ideally should come from firebase, as the firstTime variable here https://github.com/ltdelia/TrainTime/blob/master/train.js#L41. That can be done with something like firstTime = childSnapshot.val().firstTime;

ltdelia commented 8 years ago

The loading error had to do with my Firebase deploy...the CSS/JS should be linked now: https://choochoocheechee.firebaseapp.com/. I've also updated the code in Github, and it seems to be working properly now, both locally and on my Firebase app.

Thanks Faisal!