search

ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.45k stars 143 forks source link

[suggestion] "style prompt" support for ImpactWildcardEncode (and ImpactWildcardProcessor) #135

Closed Ratinod closed 10 months ago

Ratinod commented 10 months ago

ImpactWildcardEncode is an incredibly handy node! It allows you to conveniently use LORA. It allows you to use wildcards. And only one small thing is missing for this node to become perfect - style prompt support. Of course, there are already nodes that allow you to add all this to ComfyUI: style_right_now But... I can't get them to make friends with ImpactWildcardEncode. They also use different file formats (.csv (like in the automatic1111) and .json). I propose to add support for style prompt. And add your own node to select the style prompt file. It should probably look something like this: style_su example: style_work

ltdrdata commented 10 months ago

There is a somewhat complex issue here. Currently, the decision for ImpactWildcard... to pass execution from the browser to the workflow in order to record the determined prompt happens at the moment of execution. On the other hand, for the styler nodes, the execution occurs once the values have been determined. I will consider how to support style feature within ImpactWildcard...

Ratinod commented 10 months ago

Yes. It's a pity that ComfyUI doesn't support live preview (dynamic change) in nodes at least for text. Then something like this could be done: style_dynpre The gray text is a preview of the added style. White text is your prompt. I hope you find the best solution.

ltdrdata commented 10 months ago

Using the 2b20654cddd68a414b50ee2812775730547afa4d update, you can incorporate the styler as follows.

styler

populated_text is added.