ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.45k stars 144 forks source link

Plz make the ImpactWildcardEncode find the path automatic(if without) #201

Closed xueqing0622 closed 9 months ago

xueqing0622 commented 9 months ago

Plz make the ImpactWildcardEncode find the path automatic(if without)

Sp231006-075632

for example power prompt https://github.com/rgthree/rgthree-comfy and https://github.com/skfoo/ComfyUI-Coziness/

ltdrdata commented 9 months ago

I'll update it later.

xueqing0622 commented 9 months ago

Thx, plz make wildcard find the path automatic too

ltdrdata commented 9 months ago

Thx, plz make wildcard find the path automatic too

I plan to allow omitting the subfolder path only when the Lora name is unique, and not has a subfolder specification in prompt.

xueqing0622 commented 9 months ago

Thx, plz make wildcard find the path automatic too

I plan to allow omitting the subfolder path only when the Lora name is unique, and not has a subfolder specification in prompt.

we can let it have judgment, if there is a path, then the priority of the path, if it can not find the lora, and then go to auto search. There are many friends used sdwebui befores, or directly paste the civitai's prompt for testing lora and checkpoint , they really need to have no path to auto search for features

but, it is your choice, how about "add wildcard to prompt" button just like "select to add Lora" button

Still thx for such good extension, have a nice day!

ltdrdata commented 9 months ago

Thx, plz make wildcard find the path automatic too

I plan to allow omitting the subfolder path only when the Lora name is unique, and not has a subfolder specification in prompt.

we can let it have judgment, if there is a path, then the priority of the path, if it can not find the lora, and then go to auto search. There are many friends used sdwebui befores, or directly paste the civitai's prompt for testing lora and checkpoint , they really need to have no path to auto search for features

but, it is your choice, how about "add wildcard to prompt" button just like "select to add Lora" button

Still thx for such good extension, have a nice day!

If you're talking about wildcards instead of Lora, you can use an asterisk (). Both `__flowerand*/Flower__` are possible. In this case, all items belonging to that name pattern wildcard will be the targets.

It is updated, recently.

https://github.com/ltdrdata/ComfyUI-extension-tutorials/blob/Main/ComfyUI-Impact-Pack/tutorial/ImpactWildcard.md#syntax

xueqing0622 commented 9 months ago

no I mean to add a button like this Sp231006-185036 Sp231006-185238

ltdrdata commented 9 months ago

no I mean to add a button like this Sp231006-185036 Sp231006-185238

This is added on 6391fcb4577a0d79db09f3ba665f47a5aad9e132

xueqing0622 commented 9 months ago

no show add wildcard button, but show error"

Prompt outputs failed validation ImpactWildcardEncode:

ltdrdata commented 9 months ago

no show add wildcard button, but show error"

Prompt outputs failed validation ImpactWildcardEncode:

  • Required input is missing: Select to add Wildcard

Refresh your browser.

ltdrdata commented 9 months ago

no show add wildcard button, but show error"

Prompt outputs failed validation ImpactWildcardEncode:

  • Required input is missing: Select to add Wildcard

That is fixed now. The issue was due to the Wildcard selector being improperly initialized. Now, the newly added ImpactWildcard should not trigger any errors. For the Wildcard nodes that have already been added, please ensure to touch the combo that is currently set to null or undefined at least once.

xueqing0622 commented 9 months ago

yes, it works!

Hope you can add ImpactWildcardEncode lora find the path automatic

https://civitai.com/models/45448/full-feature-fantasy-prompts-characters

you can take a look of this wildcard: it use lora too: but the lora have no path, I download the loras and need to Put it in some sort of folder.

full-prompt-fantasy.txt

ltdrdata commented 9 months ago

yes, it works!

Hope you can add ImpactWildcardEncode lora find the path automatic

https://civitai.com/models/45448/full-feature-fantasy-prompts-characters

you can take a look of this wildcard: it use lora too: but the lora have no path, I download the loras and need to Put it in some sort of folder.

full-prompt-fantasy.txt

Now auto detection of lora supported on d2c2aa061a6cbf86dd4baf815dd73dd14feb3665

xueqing0622 commented 9 months ago

Yes, it works! Thx a lot!

xueqing0622 commented 9 months ago

By the way, if the wild card or path have "space (keyboard)" , it will ignore the wildcard Sp231007-121047

xueqing0622 commented 9 months ago

Sp231007-121606 wildcard path auto-detection no finish! if your have time, plz make wildcard path auto-detection too,

https://civitai.com/models/45448/full-feature-fantasy-prompts-characters Because I also download the wildcards and need to Put it in some sort of folder,

and in some case, wildcard include other wildcards: for example:the "character" wildcard include "eyecolor, hair-color, hair-female" wildcards, but they all in path "fullfeaturecharacter_v13/", so it can't read include wildcard if without wildcard path auto-detection Sp231007-121712

character.txt eyecolor.txt hair-color.txt hair-female.txt

xueqing0622 commented 9 months ago

you can see, with lora wildcard path auto-detection, just one wildcard have such good result, Sp231007-123438

Sp231007-124128

ltdrdata commented 9 months ago

By the way, if the wild card or path have "space (keyboard)" , it will ignore the wildcard Sp231007-121047

Yup. That is not allowed. It leads confusing of prompt. So. I have no plan to support it.

xueqing0622 commented 9 months ago

There are a little bug when convert wildcardText to input and convert back to widget, it is not work ! Sp231007-135230

ltdrdata commented 9 months ago

There are a little bug when convert wildcardText to input and convert back to widget, it is not work ! Sp231007-135230

This is a conflict between pythongosssss's script. I recommend just don't do that.