ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.79k stars 168 forks source link

Regional Prompt Denoise Can Cause Step Issues #251

Open sedetweiler opened 11 months ago

sedetweiler commented 11 months ago

When you set the denoise to something like .6, it will work on the region as expected, but will also take the step count way over the specified number and will cause the rest of the image to suffer from overworking. image

ltdrdata commented 11 months ago

Mentioning 0.6 appears to signify i2i. Once it exceeds 0.6, the influence of noise is expected to become stronger than that of the original image. An increase in the influence of noise implies that the structural impact determined by the seed becomes stronger. This might lead to a phenomenon of contention.

I have created a workflow that allows you to set up conditioning in a manner similar to the Regional Prompt. Essentially, It is a wrapper of the Conditioning Set Mask in a more convenient style. While there are some functional constraints compared to the Regional Sampler, it will generate much more natural images.

https://github.com/ltdrdata/ComfyUI-extension-tutorials/blob/Main/ComfyUI-Inspire-Pack/workflow/regional-conditioning-img2img.png

sedetweiler commented 11 months ago

I had the denoise set at .6 to help with coherence over the initial face. However, the rest of the image gets so damaged from the process. I wish that overlap setting worked to protect the rest of the unmasked assets.

On Sat, Oct 28, 2023, 7:39 AM Dr.Lt.Data @.***> wrote:

Mentioning 0.6 appears to signify i2i. Once it exceeds 0.6, the influence of noise is expected to become stronger than that of the original image. An increase in the influence of noise implies that the structural impact determined by the seed becomes stronger. This might lead to a phenomenon of contention.

I have created a workflow that allows you to set up conditioning in a manner similar to the Regional Prompt. Essentially, It is a wrapper of the Conditioning Set Mask in a more convenient style. While there are some functional constraints compared to the Regional Sampler, it will generate much more natural images.

https://github.com/ltdrdata/ComfyUI-extension-tutorials/blob/Main/ComfyUI-Inspire-Pack/workflow/regional-conditioning-img2img.png

— Reply to this email directly, view it on GitHub https://github.com/ltdrdata/ComfyUI-Impact-Pack/issues/251#issuecomment-1783798169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB72USITWXIYDHMMVSRKDLTYBT4HRAVCNFSM6AAAAAA6TUNYWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTG44TQMJWHE . You are receiving this because you authored the thread.Message ID: @.***>