search

ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.62k stars 154 forks source link

Request: "Make Tile Segs" with controlnet #448

Open lingondricka2 opened 7 months ago

lingondricka2 commented 7 months ago

I got good results upscaling with "Make Tile Segs", almost at the level of Magnific.ai but not quite there, any chance you can make it work with controlnet? ComfyUI_temp_hoixn_00106_

ltdrdata commented 7 months ago

I have a plan for that.

ltdrdata commented 7 months ago

image

Give it a try this way. If I recall correctly, there were VRAM issues with the segs_preprocessor when testing it while creating MakeTileSEGS. However, when I tested it with control_image last night, there were no issues.

I plan to take a closer look at the segs_preprocessor later on.

lingondricka2 commented 6 months ago

The controlnet seems to be working, but I'm struggling to get good results, I get better image quality using SDXL, but because of the lack of either tile or pix2pix controlnet for SDXL I'm getting unwanted hallucinations and noticeable seams with high denoise. Atm keeping denoise under 0.5 without controlnet gives me better results but will continue testing.

Also there is the vram issues of using a depth preprocessor on a 4k image, maybe you can modify a detailer node to upscale? I mean it already does, maybe remove guide_size and max_size and have upscale_by instead?

edit: There is a blur controlnet for SDXL using LLLiteLoader

ltdrdata commented 6 months ago

I also encountered the same issue in the depth controlnet. It seems like something that needs to be investigated.

ltdrdata commented 4 months ago

The controlnet seems to be working, but I'm struggling to get good results, I get better image quality using SDXL, but because of the lack of either tile or pix2pix controlnet for SDXL I'm getting unwanted hallucinations and noticeable seams with high denoise. Atm keeping denoise under 0.5 without controlnet gives me better results but will continue testing.

Also there is the vram issues of using a depth preprocessor on a 4k image, maybe you can modify a detailer node to upscale? I mean it already does, maybe remove guide_size and max_size and have upscale_by instead?

edit: There is a blur controlnet for SDXL using LLLiteLoader

Maybe the controlnet vram issue is related to this. https://github.com/comfyanonymous/ComfyUI/commit/0a03009808a5ad13fa3a44edbabcae68576c3982