Open lingondricka2 opened 7 months ago
I have a plan for that.
Give it a try this way. If I recall correctly, there were VRAM issues with the segs_preprocessor
when testing it while creating MakeTileSEGS
. However, when I tested it with control_image
last night, there were no issues.
I plan to take a closer look at the segs_preprocessor
later on.
The controlnet seems to be working, but I'm struggling to get good results, I get better image quality using SDXL, but because of the lack of either tile or pix2pix controlnet for SDXL I'm getting unwanted hallucinations and noticeable seams with high denoise. Atm keeping denoise under 0.5 without controlnet gives me better results but will continue testing.
Also there is the vram issues of using a depth preprocessor on a 4k image, maybe you can modify a detailer node to upscale? I mean it already does, maybe remove guide_size and max_size and have upscale_by instead?
edit: There is a blur controlnet for SDXL using LLLiteLoader
I also encountered the same issue in the depth controlnet. It seems like something that needs to be investigated.
The controlnet seems to be working, but I'm struggling to get good results, I get better image quality using SDXL, but because of the lack of either tile or pix2pix controlnet for SDXL I'm getting unwanted hallucinations and noticeable seams with high denoise. Atm keeping denoise under 0.5 without controlnet gives me better results but will continue testing.
Also there is the vram issues of using a depth preprocessor on a 4k image, maybe you can modify a detailer node to upscale? I mean it already does, maybe remove guide_size and max_size and have upscale_by instead?
edit: There is a blur controlnet for SDXL using LLLiteLoader
Maybe the controlnet vram issue is related to this. https://github.com/comfyanonymous/ComfyUI/commit/0a03009808a5ad13fa3a44edbabcae68576c3982
I got good results upscaling with "Make Tile Segs", almost at the level of Magnific.ai but not quite there, any chance you can make it work with controlnet?![ComfyUI_temp_hoixn_00106_](https://github.com/ltdrdata/ComfyUI-Impact-Pack/assets/155384738/d59163b0-ffaa-4f81-a938-28b3c747855d)