search

ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.44k stars 144 forks source link

Recent `numpy` change #651

Closed polarathene closed 1 week ago

polarathene commented 1 week ago

This commit lacks context, no issue/PR referenced.

While it's clear what it's intended to do as an intermediary fix, it is a transitive dep but now added explicitly just to workaround the current breakage concern, without any contextual comment for better visibility.

FWIW, the change only updated requirements.txt, thus diverging from pyproject.toml, assuming you'd want to carry it over there as well.

ltdrdata commented 1 week ago

The issue with numpy 2.0 is that it is not backward compatible, causing many packages that depend on numpy to break completely at now.

https://github.com/comfyanonymous/ComfyUI/issues/3794 https://github.com/Comfy-Org/comfy-cli/issues/97 https://github.com/Fannovel16/comfyui_controlnet_aux/issues/311