search

ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.44k stars 144 forks source link

ControlBridge causing needless regeneration #653

Closed enn-nafnlaus closed 1 week ago

enn-nafnlaus commented 1 week ago

Simple demonstration attached.

ControlBridgeProblem.json

It's easy enough to recreate.

1) Load an upscale model using "Load Upscale Model" 2) Route the upscale model to a control bridge 3) Route the output of the control bridge to an "Upscale Image (using Model)". 4) Give the upscaler an empty or loaded image to upscale and a preview image output.

Now keep clicking Queue Prompt. It will generate an image every time.

Now eliminate the Control Bridge from the workflow - route the model straight to the upscaler. It will generate once the first time, but after that, it will use the cached image and not force regeneration (the proper behavior).

In short, the ControlBridge is breaking this caching behavior, which can lead to greatly slowing down complex workflows - something Control Bridge is, ironically, designed to prevent :)

ltdrdata commented 1 week ago

This is patched.

enn-nafnlaus commented 1 week ago

This is patched.

Great, thanks - will try it out this evening! :)