search

ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.68k stars 159 forks source link

Lack of portability and futureproofing #675

Open gibthrowaway72 opened 1 month ago

gibthrowaway72 commented 1 month ago

ComfyUI, unlike A111 is software that can be installed in a fully offfline enviroment, it is a self-contained, portable package.

Taking into consideration that this extension is for ComfyUI, I think that it would be best if that spirit were to be preserved here. Installing Impact Pack should not require getting git, or using a CMD to download dependencies (that could very well go offline) over the network.

A self-contained package containing all necessary dependencies that can be installed in an isolated machine would be more welcome. Even if it is only updated for major releases due to the time necessary that it takes to create one.

Please consider this issue to be opened out of care for this repo. It would be very sad to see all this work rot away all because some day a dependency went missing or the way git installs things ceases to function.

gibthrowaway72 commented 1 month ago

As a matter of fact, since I know that creating portable releases is something that a lot of developers despise, I would be fine with just information on how to download and prep this extension without using git. And a list of where I can find and manually download the dependencies that it has. This way I could create a portable release for myself.

None the less, I urge the developer to consider making a portable release. I believe that ComfyUI's success comes from it, not from its UI. The avereage user cant be trusted with inputing git console commands. A portable package that is easier to install would probably create a surge in popularity (and the benefits that come with that, such as donations). On top of that, I believe that considering this from the point of view of software preservation is important too. Any software that cant be archived easily is software that will one day undoubtably become lost.

I apologize for my poor English. I am asian and self taught myself english, like computers. I hope my poor grammar does not dissaude you from comprehending my point, and understanding the appeal of my arguments. I wish you a blessed time.

ltdrdata commented 1 month ago

Improvements to the package installation method are planned for the future.