search

ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.91k stars 188 forks source link

Clarifications on Control Bridge behavior #732

Open alessandroperilli opened 2 months ago

alessandroperilli commented 2 months ago

I think I'm doing something wrong. Or I misunderstood what Control Bridge can do.

I have this situation:

Screenshot 2024-09-04 at 22 32 42

where, given a certain condition, two Control Bridge nodes must block a Discord bot from serving a text answer (8527 > 8528) and an image answer (8545 > 7339).

The textual answer is correctly blocked. The image answer is correctly, blocked, too. However, the Get_Final_Image node doesn't seem to be blocked, so the image gets generated anyway, even if the bot doesn't send it to the Discord user.

I thought that, with the STOP command, Control Bridge would be able to block every node connected to the one directly linked to it. But it doesn't seem the case.

Can you help me understand better?

Thank you.

ltdrdata commented 2 months ago

Currently, due to a bug in execution system in core, the Stop behavior is malfunctioning. Please wait until this issue is patched.

alessandroperilli commented 2 months ago

So I was not wrong in my assumption. Thank you!

ltdrdata commented 2 months ago

That is fixed. https://github.com/comfyanonymous/ComfyUI/pull/4836

Try again.

alessandroperilli commented 2 months ago

Unfortunately, it's still processing the entire pipeline that depends on that Get node and generating the image.

ltdrdata commented 2 months ago

control-bridge-test

Please check if this workflow is functioning correctly. It's a simple workflow that performs the subsequent steps if a face is detected, and blocks if no face is detected.

According to my test, it works properly in latest ComfyUI.

Above workflow is functioning correctly, but if your workflow is not working properly, please create and upload a simple workflow that reproduces your issue.