ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.91k stars 188 forks source link

Detailer (SEGS/Pipe) takes ages to load with Flux #745

Closed sahinincik closed 2 months ago

sahinincik commented 2 months ago

I'm trying to use Detailer with Flux, I've updated Impact Pack to the latest version. It looks like it's loading models again, it wait a long time before generation.

image

image

ltdrdata commented 2 months ago

This is not an issue with the Impact Pack, but an issue with the core.

When performing a basic workflow example using SamplerCustomAdvanced, you can confirm that it occurs during the SamplerCustomAdvanced step. The Detailer is affected because it uses SamplerCustomAdvanced.

seasnakes commented 2 months ago

This is not an issue with the Impact Pack, but an issue with the core.

When performing a basic workflow example using SamplerCustomAdvanced, you can confirm that it occurs during the SamplerCustomAdvanced step. The Detailer is affected because it uses SamplerCustomAdvanced.

Could you kindly provide an example detailer workflow for the Flux version? Thank you.🙏

sahinincik commented 2 months ago

any way around this?

ltdrdata commented 2 months ago

This is not an issue with the Impact Pack, but an issue with the core. When performing a basic workflow example using SamplerCustomAdvanced, you can confirm that it occurs during the SamplerCustomAdvanced step. The Detailer is affected because it uses SamplerCustomAdvanced.

Could you kindly provide an example detailer workflow for the Flux version? Thank you.🙏

https://github.com/ltdrdata/ComfyUI-extension-tutorials/blob/Main/ComfyUI-Impact-Pack/workflow/flux-detailer.png

Just use Negative Cond Placeholer. You can use it with Impact/Inspire samplers and Detailers.