ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.91k stars 187 forks source link

An installation problem, how to solve it #768

Closed LiuGe126 closed 1 month ago

LiuGe126 commented 1 month ago

Loading: ComfyUI-Impact-Pack (V7.9)

[Impact Pack] Failed to import due to several dependencies are missing!!!! Traceback (most recent call last): File "D:\LIUGEGE\ComfyUI\nodes.py", line 1998, in load_custom_node module_spec.loader.exec_module(module) File "", line 940, in exec_module File "", line 241, in _call_with_frames_removed File "D:\LIUGEGE\ComfyUI\custom_nodes\ComfyUI-Impact-Pack__init__.py", line 53, in raise e File "D:\LIUGEGE\ComfyUI\custom_nodes\ComfyUI-Impact-Pack__init__.py", line 31, in import impact.subpack_nodes # This import must be done before cv2. ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ModuleNotFoundError: No module named 'impact.subpack_nodes'

Cannot import D:\LIUGEGE\ComfyUI\custom_nodes\ComfyUI-Impact-Pack module for custom nodes: No module named 'impact.subpack_nodes'

ltdrdata commented 1 month ago

Please attach the comfyui.log file that was generated during the process of uninstalling and reinstalling the Impact Pack in ComfyUI-Manager, followed by restarting ComfyUI

LiuGe126 commented 1 month ago

Please attach the comfyui.log file that was generated during the process of uninstalling and reinstalling the Impact Pack in ComfyUI-Manager, followed by restarting ComfyUI请附加在ComfyUI-Manager中卸载和重新安装Impact Pack过程中生成的文件,然后重新启动ComfyUI

comfyui.log thanks

ltdrdata commented 1 month ago

Is this the correct log after reinstalling the Impact Pack and restarting ComfyUI?

LiuGe126 commented 1 month ago

Is this the correct log after reinstalling the Impact Pack and restarting ComfyUI?

I can install it normally after uninstalling and reinstalling it again, but I have uninstalled and reinstalled it for many times before, but it has no effect. Thank you for your reply.

Ryuukeisyou commented 1 month ago

I try a clean install and it seems that the install code to git clone the subpack repo is not run before __init__.py

ltdrdata commented 1 month ago

I try a clean install and it seems that the install code to git clone the subpack repo is not run before __init__.py

Aren't you installing through ComfyUI-Manager? This installation process is automatically performed when installing through ComfyUI-Manager.

Ryuukeisyou commented 1 month ago

I try a clean install and it seems that the install code to git clone the subpack repo is not run before __init__.py

Aren't you installing through ComfyUI-Manager? This installation process is automatically performed when installing through ComfyUI-Manager.

not through manager, basically it's not a problem. just need to run install when git cloned mannually.

drmbt commented 1 month ago

is there any way to include this in normal init.py instead of only when installed through comfy manager? impact pack has been broken for me through a dynamically built docker container situation I've got going on because of this, everything else I'm running works great when procedurally git cloned

ltdrdata commented 1 month ago

is there any way to include this in normal init.py instead of only when installed through comfy manager? impact pack has been broken for me through a dynamically built docker container situation I've got going on because of this, everything else I'm running works great when procedurally git cloned

I'm planning to change the subpack structure anyway.

ltdrdata commented 1 month ago

I try a clean install and it seems that the install code to git clone the subpack repo is not run before __init__.py

Aren't you installing through ComfyUI-Manager? This installation process is automatically performed when installing through ComfyUI-Manager.

not through manager, basically it's not a problem. just need to run install when git cloned mannually.

install-manual.py is added.