search

ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.9k stars 186 forks source link

Install subpack dependencies #773

Closed ivan-tolkunov closed 1 month ago

ivan-tolkunov commented 1 month ago

Added pip install for ComfyUI Impact Subpack. The ultralytics package is not installed and this cause the problem:

> WARNING:root:Traceback (most recent call last):
>   File "/comfyui/nodes.py", line 1998, in load_custom_node
>     module_spec.loader.exec_module(module)
>   File "<frozen importlib._bootstrap_external>", line 883, in exec_module
>   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
>   File "/comfyui/custom_nodes/ComfyUI-Impact-Pack/__init__.py", line 53, in <module>
>     raise e
>   File "/comfyui/custom_nodes/ComfyUI-Impact-Pack/__init__.py", line 31, in <module>
>     import impact.subpack_nodes  # This import must be done before cv2.
>   File "/comfyui/custom_nodes/ComfyUI-Impact-Pack/impact_subpack/impact/subpack_nodes.py", line 4, in <module>
>     import impact.subcore as subcore
>   File "/comfyui/custom_nodes/ComfyUI-Impact-Pack/impact_subpack/impact/subcore.py", line 17, in <module>
>     raise e
>   File "/comfyui/custom_nodes/ComfyUI-Impact-Pack/impact_subpack/impact/subcore.py", line 13, in <module>
>     from ultralytics import YOLO
> ModuleNotFoundError: No module named 'ultralytics'

This could also be a solution for the issue #689

ltdrdata commented 1 month ago

In fact, it was intentionally removed, assuming it would be installed through the Manager.

This was done to eliminate the Manager's blind spot and prevent changes in the versions of already installed dependencies.

For manual installation, it seems better to keep the current install.py and provide a separate install-manual.py

ltdrdata commented 1 month ago

install-maual.py is added for manual installation.