search

ltdrdata / ComfyUI-Impact-Pack

Custom nodes pack for ComfyUI This custom node helps to conveniently enhance images through Detector, Detailer, Upscaler, Pipe, and more.
GNU General Public License v3.0
1.91k stars 187 forks source link

Feature Request: Recognize # as a comment (skip line) with Impact Wildcards #789

Closed EnragedAntelope closed 1 month ago

EnragedAntelope commented 1 month ago

Hi, Lately I've seen a decent amount of wildcards include credits or instructions etc. with # at the beginning of a line. Impact Wildcard Processor includes these lines when referencing the wildcard, but should not. Can this be updated to correctly recognize # as meaning a comment only / skip the line?

Examples I've seen, so you can spot any relevant patterns:

#v1 by CWT - compiled from the list found on Wikipedia

# Cyberdelia Wildcards - Populair gameconsoles #

# Originally sourced from Clements Checklist v2022

# Remove or Set a # in front of a line to Activate or Deactivate the Option
# Simple add your Own Wildcards just in a new Line 
#
ltdrdata commented 1 month ago

image

There is no issue about comment.

ltdrdata commented 1 month ago

Revert to Impact Pack version to 7.10.3. If it wlll work that is a issue of https://github.com/ltdrdata/ComfyUI-Impact-Pack/issues/790

I'll patch it.

ltdrdata commented 1 month ago

Update and try again.

EnragedAntelope commented 1 month ago

I tried again with Vision Wildcards, I unfortunately still see # insertions: image

Vision wildcards are here: https://civitai.com/models/793366/simple-wildcards-vision-outfits https://civitai.com/models/823376/simple-wildcards-vision-background

ltdrdata commented 1 month ago

This is fixed.