search

ltdrdata / ComfyUI-Manager

ComfyUI-Manager is an extension designed to enhance the usability of ComfyUI. It offers management functions to install, remove, disable, and enable various custom nodes of ComfyUI. Furthermore, this extension provides a hub feature and convenience functions to access a wide range of information within ComfyUI.
GNU General Public License v3.0
6.79k stars 878 forks source link

Preview not working on custom nodes #236

Open biofaust opened 11 months ago

biofaust commented 11 months ago

Preview is not shown for certain nodes, until "restarted". I tested with Ultimate SD Upscale and ImpactPack's FaceDetailer nodes.

While the preview is always shown for the KSampler (Efficient) node, these other nodes start each run not showing a preview. Preview is shown during the same run if one goes in Manager, sets Preview setting to None, closes Manager, then reenters Manager and sets it to Auto and closes.

Also, Preview setting defaults to None upon starting ComfyUI.

My list of custom nodes is shown in the image, all nodes and ComfyUI are updated. image

ltdrdata commented 11 months ago

Can you provide steps for reproducing?

biofaust commented 11 months ago

To reproduce the preview not launching:

  1. Launch ComfyUI using run_nvidia_gpu.bat
  2. Queue any prompt including Ultimate SD Upscale and/or ImpactPack's FaceDetailer

To reproduce the "workaround":

  1. go in Manager,
  2. set Preview setting to None,
  3. close Manager,
  4. reenter Manager
  5. set Preview setting to Auto
  6. close Manager

The workaround only applies to the current prompt.

ltdrdata commented 11 months ago

To reproduce the preview not launching:

  1. Launch ComfyUI using run_nvidia_gpu.bat
  2. Queue any prompt including Ultimate SD Upscale and/or ImpactPack's FaceDetailer

To reproduce the "workaround":

  1. go in Manager,
  2. set Preview setting to None,
  3. close Manager,
  4. reenter Manager
  5. set Preview setting to Auto
  6. close Manager

The workaround only applies to the current prompt.

Ah, what I requested was not a set of actionable steps but rather a way to reproduce the phenomenon where the preview is reset to None. The issue needs to be replicated before I can complete testing after the fix. Currently, it's unclear how to reproduce the issue.

biofaust commented 10 months ago

The problem is not dependent on the setting reverting to None. The preview on the custom nodes I named does not work at each new run in the queue, and if I go to the Manager settings I can see that the setting remained at Auto if I set it like that due to applying the workaround.

ltdrdata commented 10 months ago

So, even though it's set to Auto and not None, the preview doesn't show up? Are you, by any chance, using ComfyUI with multiple tabs open?

biofaust commented 10 months ago

Yes, I am using ComfyUI in a browser with other tabs open.

On Sun, Dec 24, 2023, 11:24 Dr.Lt.Data @.***> wrote:

So, even though it's set to Auto and not None, the preview doesn't show up? Are you, by any chance, using ComfyUI with multiple tabs open?

— Reply to this email directly, view it on GitHub https://github.com/ltdrdata/ComfyUI-Manager/issues/236#issuecomment-1868483404, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHEXZQ75B2CQGNAKNVQEEDYK77FBAVCNFSM6AAAAABARBQOF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGQ4DGNBQGQ . You are receiving this because you authored the thread.Message ID: @.***>

ltdrdata commented 10 months ago

Yes, I am using ComfyUI in a browser with other tabs open. … On Sun, Dec 24, 2023, 11:24 Dr.Lt.Data @.> wrote: So, even though it's set to Auto and not None, the preview doesn't show up? Are you, by any chance, using ComfyUI with multiple tabs open? — Reply to this email directly, view it on GitHub <#236 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHEXZQ75B2CQGNAKNVQEEDYK77FBAVCNFSM6AAAAABARBQOF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGQ4DGNBQGQ . You are receiving this because you authored the thread.Message ID: @.>

My intention is whether you have multiple ComfyUI tabs open.

Next, I'm inquiring if, without making any changes to the preview option, the issue persists, where the preview doesn't appear even though it's not set to None.

biofaust commented 10 months ago

Ah, I see. No, only one ComfyUI tab open.

On Sun, 24 Dec 2023 at 12:49, Dr.Lt.Data @.***> wrote:

Yes, I am using ComfyUI in a browser with other tabs open. … <#m-1336743352154034828> On Sun, Dec 24, 2023, 11:24 Dr.Lt.Data @.> wrote: So, even though it's set to Auto and not None, the preview doesn't show up? Are you, by any chance, using ComfyUI with multiple tabs open? — Reply to this email directly, view it on GitHub <#236 (comment) https://github.com/ltdrdata/ComfyUI-Manager/issues/236#issuecomment-1868483404>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHEXZQ75B2CQGNAKNVQEEDYK77FBAVCNFSM6AAAAABARBQOF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGQ4DGNBQGQ https://github.com/notifications/unsubscribe-auth/AAHEXZQ75B2CQGNAKNVQEEDYK77FBAVCNFSM6AAAAABARBQOF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGQ4DGNBQGQ . You are receiving this because you authored the thread.Message ID: @.>

My intention is whether you have multiple ComfyUI tabs open.

Next, I'm inquiring if, without making any changes to the preview option, the issue persists, where the preview doesn't appear even though it's not set to None.

— Reply to this email directly, view it on GitHub https://github.com/ltdrdata/ComfyUI-Manager/issues/236#issuecomment-1868498075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHEXZQNKG2FENH5N5VBC5DYLAJFZAVCNFSM6AAAAABARBQOF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGQ4TQMBXGU . You are receiving this because you authored the thread.Message ID: @.***>