ltdrdata / ComfyUI-extension-tutorials

579 stars 32 forks source link

Detailer Cropped vs Cropped Refined? #28

Closed ckao10301 closed 2 months ago

ckao10301 commented 10 months ago

Cropped Refined result looks better than Cropped, but Cropped Refined is not getting applied to the final image-it appears that Cropped is being applied instead. Is that intended? What's the difference between Cropped and Cropped_refined?

image
ltdrdata commented 10 months ago

Increase the "denoise" to 1.0, and you should be able to clearly identify what has been applied. Also, to easily check the range of the applied image, it provides "cropped_refined_alpha." Take a look at that.

ckao10301 commented 10 months ago

Hmmm, now that I'm considering the "cropped_refined_alpha", I can't tell which one is being applied. I just thought the blending on cropped_refined looked better. What exactly is the difference between "cropped" and "cropped refined"?

image
ltdrdata commented 10 months ago

Hmmm, now that I'm considering the "cropped_refined_alpha", I can't tell which one is being applied. I just thought the blending on cropped_refined looked better. What exactly is the difference between "cropped" and "cropped refined"?

image

That's definitely a bug. "cropped" should display the original as it is, but it seems that the refined result is effecting to cropped, too.

ltdrdata commented 10 months ago

I just tested it, but I don't experience such symptoms. Could you please share your workflow with me?

ckao10301 commented 10 months ago

Hmmm, now that I'm considering the "cropped_refined_alpha", I can't tell which one is being applied. I just thought the blending on cropped_refined looked better. What exactly is the difference between "cropped" and "cropped refined"?

image

That's definitely a bug. "cropped" should display the original as it is, but it seems that the refined result is effecting to cropped, too.

Yes, from my experience "cropped" doesn't show the original image, it shows the newly generated image. Here are the input images and workflow json is below.

coworkers (45) mask_00023_ (4) _test workflow.json

12309kajsd8123b commented 2 months ago

Hi. I think I have re-created this issue in my instance. From the magnified view it is clear that the cropped view gets applied, not cropped refined. There is a clear line of skin tone difference under the chin that is only visible on the cropped version. screen example

ltdrdata commented 2 months ago

This is fixed.