ltdrdata / ComfyUI-extension-tutorials

536 stars 33 forks source link

quantifying wildcard - breaking change #50

Open C0rn-Fl4k3s opened 2 months ago

C0rn-Fl4k3s commented 2 months ago

Please revert your change with "quantifying wildcard" which say to use the synthax "$$count#wildcards". This is a breaking change for me who write and publish wildcards, specially since this a diverging implementation from wildcard plugins for other web-ui such as https://github.com/adieyal/sd-dynamic-prompts/blob/main/docs/SYNTAX.md

The result is this prompt won't call twice the wildcard as it did before: {2$$cornf-fantasy-house/surrounding}

By the way the new synthax does not work as intended, or it is not intuitive, or the example given in the documentation is wrong : {2$$, $$5#wildcards} turns into {2$$, $$wildcards|wildcards|wildcards|wildcards|wildcards}

ltdrdata commented 2 months ago

{2$$, $$5#wildcards} is functioning as intended. Due to 5#wildcards, 'wildcards' is repeated 5 times, becoming wildcards|wildcards|wildcards|wildcards|wildcards, and {2$$, $$} selects 2 items from the options and concatenates them with a comma.

i.e. it is populated to wildcards, wildcards

It's just that some parts of the documentation are incorrect. It should be count#wildcards instead of $$count#wildcards.

https://github.com/ltdrdata/ComfyUI-extension-tutorials/blob/Main/ComfyUI-Impact-Pack/tutorial/ImpactWildcard.md#syntax

{<count>$$<single wildcard option>} syntax is a grammar that has never been supported. If it seemed to work that way, it was a bug.

ltdrdata commented 2 months ago

Btw, I updated Impact Pack to support {<count>$$<single wildcard option>} pattern.

C0rn-Fl4k3s commented 2 months ago

Thanks a lot :3

C0rn-Fl4k3s commented 2 months ago

Sorry for coming back on this issue, would it be possible to add a "comma" by default as a separator ? I feel like it was forgotten ^^"