Code style improvements

[longnd]

The application seems to not follow a common coding style guide, e.g Ruby style guide so several places can be improved for a better code style

• No spaces should be used in percent literal delimiters https://github.com/ltenzil/scrape/blob/6eb163261a9102f748fc789147840f7856584ef8/app/controllers/keywords_controller.rb#L3
• Empty method definition can be put in a single line https://github.com/ltenzil/scrape/blob/6eb163261a9102f748fc789147840f7856584ef8/app/controllers/keywords_controller.rb#L27-L28
• The methods under private keyword should be on the same indent as the other method https://github.com/ltenzil/scrape/blob/6eb163261a9102f748fc789147840f7856584ef8/app/controllers/keywords_controller.rb#L92-L101
• redundant empty lines in several places https://github.com/ltenzil/scrape/blob/6eb163261a9102f748fc789147840f7856584ef8/app/views/keywords/show.html.haml#L30-L34 https://github.com/ltenzil/scrape/blob/6eb163261a9102f748fc789147840f7856584ef8/spec/models/keyword_spec.rb#L83-L86

by using a gem like rubocop, it would help to prevent these issues

[ltenzil]

Yes I have used it before. I missed those blank space, my bad.

I have different opinions on: (I like it this way)

• Empty method definition can be put in a single line
• The methods under private keyword should be on the same indent as the other method

[ltenzil]

Resolved in #21

[longnd]

Yes I have used it before.

May I know why you don't use it anymore, or why you just don't use it in this code challenge? IMO, following a coding styleguide would be helpful to keep the codestyle consistent & easy to read to other people.

I have different opinions on: (I like it this way)

when you use Rubocop, did you make some exceptions like that while other people still follow the common styleguide?

[ltenzil]

Long ago before using Rubocop, I went with my own style. In my own projects, when controllers doesn't have much methods under private. so I used to indent it. which happened to help me. Models usually i don't indent.

And my exceptions are with my personal projects only where i learn stuff trying to do things differently. Before accepting the rule (pros), I need to understand the cons by a working on a piece of code.

My exceptions are not with the projects where i work as a team. And with organization projects, everyone in team follows the selected style guide. I remember using a commit hook which throws warning. There are few legacy projects, i worked which doesn't go well with Rubocop.

I remember one of the exceptions, we had in team's style guide => 'Style/RedundantBegin was set to false.' I believe every team has their own exceptions.