search

ltenzil / scrape

Scrape talks about building reports on user entered keywords and its search results (Google)
0 stars 0 forks source link

Test - incorrect description #18

Closed longnd closed 2 years ago

longnd commented 2 years ago

This test description isn't accurate, the expected behavior is to return a failure error I belive https://github.com/ltenzil/scrape/blob/6eb163261a9102f748fc789147840f7856584ef8/spec/models/keyword_spec.rb#L76-L82

Moreover, the test should be grouped under context

context "given search quota reached"
  it "returns a failure"
ltenzil commented 2 years ago

my bad. will modify it

ltenzil commented 2 years ago

I have copied from above test case. it should "return quota error" My bad

ltenzil commented 2 years ago

Resolved in #21

longnd commented 2 years ago

The fix solved this issue.